Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ferretdb_ prefix to our custom build tags #869

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 8, 2022

To avoid possible conflicts.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 8, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jul 8, 2022
@AlekSi AlekSi requested a review from rumyantseva as a code owner July 8, 2022 18:13
@AlekSi AlekSi self-assigned this Jul 8, 2022
@AlekSi AlekSi enabled auto-merge (squash) July 8, 2022 18:13
@AlekSi AlekSi requested review from a team, seeforschauer and noisersup and removed request for a team July 8, 2022 18:13
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #869 (cce19a7) into main (d687477) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   59.37%   59.34%   -0.04%     
==========================================
  Files         218      218              
  Lines        9833     9833              
==========================================
- Hits         5838     5835       -3     
- Misses       3299     3301       +2     
- Partials      696      697       +1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
Flag Coverage Δ
integration 61.83% <0.00%> (-0.04%) ⬇️
mongodb 18.92% <0.00%> (-0.04%) ⬇️
pg 61.76% <0.00%> (-0.04%) ⬇️
unit 24.93% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the trust PRs that can access Actions secrets label Jul 8, 2022
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 0661f02 into FerretDB:main Jul 8, 2022
@AlekSi AlekSi deleted the namespace-tags branch July 8, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants