Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tip to limit concurrent tasks #883

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

rumyantseva
Copy link
Member

@rumyantseva rumyantseva commented Jul 13, 2022

Description

A tiny doc improvement on how to limit concurrent tasks.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva requested a review from a team July 13, 2022 11:29
@rumyantseva rumyantseva requested a review from AlekSi as a code owner July 13, 2022 11:29
@rumyantseva rumyantseva self-assigned this Jul 13, 2022
@rumyantseva rumyantseva added the documentation Something user-visible is badly or not documented label Jul 13, 2022
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi added this to the v0.5.1 milestone Jul 13, 2022
@AlekSi AlekSi requested review from a team, w84thesun and seeforschauer and removed request for a team July 13, 2022 11:31
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #883 (6cb68cd) into main (0d32d56) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
- Coverage   59.08%   59.01%   -0.07%     
==========================================
  Files         219      219              
  Lines       10023    10023              
==========================================
- Hits         5922     5915       -7     
- Misses       3403     3411       +8     
+ Partials      698      697       -1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/pool.go 63.05% <0.00%> (-1.21%) ⬇️
internal/clientconn/conninfo/conn_info.go 83.33% <0.00%> (+16.66%) ⬆️
Flag Coverage Δ
integration 61.28% <ø> (-0.04%) ⬇️
mongodb 18.52% <ø> (-0.04%) ⬇️
pg 61.21% <ø> (-0.04%) ⬇️
unit 24.72% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva enabled auto-merge (squash) July 13, 2022 11:32
@rumyantseva rumyantseva merged commit 62b1252 into FerretDB:main Jul 13, 2022
@rumyantseva rumyantseva deleted the limit-concurrent-tasks branch July 13, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants