Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect client in embedded tests #890

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 14, 2022

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 14, 2022
@AlekSi AlekSi added this to the v0.5.1 milestone Jul 14, 2022
@AlekSi AlekSi self-assigned this Jul 14, 2022
@AlekSi AlekSi requested a review from a team as a code owner July 14, 2022 16:03
@AlekSi AlekSi requested review from rumyantseva, a team, w84thesun and noisersup and removed request for a team July 14, 2022 16:03
@AlekSi AlekSi enabled auto-merge (squash) July 14, 2022 16:04
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #890 (43df967) into main (b6f00e6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   59.34%   59.32%   -0.02%     
==========================================
  Files         225      225              
  Lines       10020    10024       +4     
==========================================
+ Hits         5946     5947       +1     
- Misses       3376     3379       +3     
  Partials      698      698              
Impacted Files Coverage Δ
integration/setup.go 87.40% <100.00%> (+0.09%) ⬆️
internal/clientconn/listener.go 78.72% <100.00%> (+0.70%) ⬆️
internal/util/ctxutil/ctxutil.go 88.23% <0.00%> (-11.77%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/clientconn/conn.go 46.79% <0.00%> (-0.76%) ⬇️
internal/handlers/pg/pgdb/databases.go 59.70% <0.00%> (+5.97%) ⬆️
Flag Coverage Δ
integration 61.55% <100.00%> (+0.07%) ⬆️
mongodb 18.51% <53.84%> (-0.34%) ⬇️
pg 61.48% <100.00%> (+0.07%) ⬆️
unit 24.65% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok'ish that we fix it this way... But!
It feels like our embedded server needs a proper Shutdown to stop gracefully. Simple context propagation is not enough.

@AlekSi AlekSi merged commit dcb5aae into FerretDB:main Jul 14, 2022
@AlekSi AlekSi deleted the disconnect branch July 14, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants