-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract parameter list into one variable in QueryDocuments
#910
Extract parameter list into one variable in QueryDocuments
#910
Conversation
QueryDocuments
Codecov Report
@@ Coverage Diff @@
## main #910 +/- ##
==========================================
- Coverage 59.08% 58.96% -0.12%
==========================================
Files 224 224
Lines 10179 10180 +1
==========================================
- Hits 6014 6003 -11
- Misses 3454 3465 +11
- Partials 711 712 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense to me.
Actually, I was thinking of moving this as part of my previous PR but decided not to make it even more huge :)
Description
This PR is a part of #167.
Explain command will add yet another parameter to the
QueryDocuments
, so this PR gathersQueryDocuments
parameters at one variable.task all
, and it passed.task godocs
.