Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract parameter list into one variable in QueryDocuments #910

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Extract parameter list into one variable in QueryDocuments #910

merged 2 commits into from
Jul 18, 2022

Conversation

seeforschauer
Copy link
Contributor

@seeforschauer seeforschauer commented Jul 18, 2022

Description

This PR is a part of #167.

Explain command will add yet another parameter to the QueryDocuments, so this PR gathers QueryDocuments parameters at one variable.

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@seeforschauer seeforschauer self-assigned this Jul 18, 2022
@seeforschauer seeforschauer added the code/enhancement Some user-visible feature could work better label Jul 18, 2022
@seeforschauer seeforschauer changed the title query-documents-param Extract parameter list into one variable in QueryDocuments Jul 18, 2022
@seeforschauer seeforschauer linked an issue Jul 18, 2022 that may be closed by this pull request
9 tasks
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #910 (931f785) into main (8f7f1d1) will decrease coverage by 0.11%.
The diff coverage is 65.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   59.08%   58.96%   -0.12%     
==========================================
  Files         224      224              
  Lines       10179    10180       +1     
==========================================
- Hits         6014     6003      -11     
- Misses       3454     3465      +11     
- Partials      711      712       +1     
Impacted Files Coverage Δ
internal/handlers/pg/pg.go 100.00% <ø> (ø)
internal/handlers/pg/msg_insert.go 41.93% <40.00%> (ø)
internal/handlers/pg/msg_count.go 46.42% <50.00%> (ø)
internal/handlers/pg/msg_find.go 66.40% <57.14%> (ø)
internal/handlers/pg/msg_update.go 52.25% <62.50%> (ø)
internal/handlers/pg/msg_delete.go 43.11% <66.66%> (ø)
internal/handlers/pg/msg_dbstats.go 65.11% <75.00%> (-6.98%) ⬇️
internal/handlers/pg/msg_findandmodify.go 77.11% <100.00%> (-0.17%) ⬇️
internal/handlers/pg/pgdb/query_documents.go 60.91% <100.00%> (+1.39%) ⬆️
... and 2 more
Flag Coverage Δ
integration 61.14% <65.85%> (-0.07%) ⬇️
mongodb 18.53% <0.00%> (-0.04%) ⬇️
pg 61.14% <65.85%> (-0.07%) ⬇️
unit 25.06% <7.31%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@seeforschauer seeforschauer marked this pull request as ready for review July 18, 2022 13:25
@seeforschauer seeforschauer requested a review from a team as a code owner July 18, 2022 13:25
@seeforschauer seeforschauer enabled auto-merge (squash) July 18, 2022 13:26
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me.

Actually, I was thinking of moving this as part of my previous PR but decided not to make it even more huge :)

@seeforschauer seeforschauer merged commit 0f8fc77 into FerretDB:main Jul 18, 2022
@seeforschauer seeforschauer deleted the query-documents-param branch July 18, 2022 15:56
@AlekSi AlekSi added this to the v0.5.1 milestone Jul 19, 2022
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/enhancement Some user-visible feature could work better labels Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support explain diagnostic command
4 participants