Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Path tests #936

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Add Path tests #936

merged 1 commit into from
Jul 22, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Jul 22, 2022

Description

This PR refs #803.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/chore Code maintenance improvements label Jul 22, 2022
@w84thesun w84thesun added this to the v0.5.1 milestone Jul 22, 2022
@w84thesun w84thesun self-assigned this Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #936 (f8fcbf8) into main (1b9a571) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   60.04%   60.01%   -0.03%     
==========================================
  Files         224      224              
  Lines       10272    10272              
==========================================
- Hits         6168     6165       -3     
- Misses       3395     3402       +7     
+ Partials      709      705       -4     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/collections.go 54.86% <0.00%> (-5.31%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/clientconn/listener.go 76.04% <0.00%> (-3.13%) ⬇️
internal/wire/msg_header.go 69.04% <0.00%> (-2.39%) ⬇️
internal/wire/msg_body.go 36.50% <0.00%> (-1.59%) ⬇️
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
internal/types/path.go 92.63% <0.00%> (+8.42%) ⬆️
Flag Coverage Δ
integration 62.25% <ø> (-0.25%) ⬇️
mongodb 18.90% <ø> (-0.04%) ⬇️
pg 62.15% <ø> (-0.25%) ⬇️
tigris 49.75% <ø> (ø)
unit 24.90% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun marked this pull request as ready for review July 22, 2022 12:09
@w84thesun w84thesun requested a review from a team as a code owner July 22, 2022 12:09
@w84thesun w84thesun requested review from AlekSi, rumyantseva, a team and seeforschauer and removed request for a team July 22, 2022 12:09
@AlekSi AlekSi enabled auto-merge (squash) July 22, 2022 12:58
@AlekSi AlekSi merged commit 77e4370 into FerretDB:main Jul 22, 2022
@w84thesun w84thesun deleted the add-path-tests branch August 4, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants