Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comment and $comment update's arguments #937

Merged
merged 14 commits into from
Jul 27, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jul 22, 2022

Description

This PR closes #487.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup requested a review from a team as a code owner July 22, 2022 15:09
@noisersup noisersup self-assigned this Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #937 (640d8f7) into main (9e5b193) will increase coverage by 0.12%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   62.00%   62.13%   +0.12%     
==========================================
  Files         228      228              
  Lines       10597    10610      +13     
==========================================
+ Hits         6571     6592      +21     
+ Misses       3251     3238      -13     
- Partials      775      780       +5     
Impacted Files Coverage Δ
internal/handlers/pg/msg_update.go 49.09% <40.00%> (-1.86%) ⬇️
internal/handlers/pg/msg_findandmodify.go 76.78% <100.00%> (ø)
internal/handlers/pg/pgdb/pool.go 67.90% <100.00%> (+1.08%) ⬆️
internal/handlers/pg/msg_dbstats.go 65.11% <0.00%> (-6.98%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/tigris/msg_ismaster.go 86.95% <0.00%> (+86.95%) ⬆️
Flag Coverage Δ
integration 56.83% <73.91%> (+0.12%) ⬆️
mongodb 18.61% <0.00%> (-0.04%) ⬇️
pg 61.57% <73.91%> (-0.08%) ⬇️
tigris 18.33% <0.00%> (+0.13%) ⬆️
unit 24.72% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as draft July 22, 2022 15:27
seeforschauer
seeforschauer previously approved these changes Jul 22, 2022
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except naming.

integration/basic_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi added this to the v0.5.1 milestone Jul 25, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ noisersup
✅ AlekSi
❌ Katerina Bletsch


Katerina Bletsch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AlekSi AlekSi modified the milestones: v0.5.1, v0.6.0 Jul 26, 2022
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Jul 26, 2022
@noisersup noisersup marked this pull request as ready for review July 26, 2022 12:56
@AlekSi AlekSi requested review from a team and w84thesun and removed request for a team July 26, 2022 12:59
w84thesun
w84thesun previously approved these changes Jul 26, 2022
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/handlers/pg/msg_update.go Show resolved Hide resolved
internal/handlers/pg/pgdb/pool.go Outdated Show resolved Hide resolved
integration/basic_test.go Show resolved Hide resolved
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last tiny correction is needed.

internal/handlers/pg/msg_update.go Outdated Show resolved Hide resolved
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva enabled auto-merge (squash) July 27, 2022 12:20
@AlekSi AlekSi disabled auto-merge July 27, 2022 12:22
@AlekSi AlekSi merged commit 024cf92 into FerretDB:main Jul 27, 2022
@noisersup noisersup deleted the comment-update-487 branch July 27, 2022 12:30
@AlekSi AlekSi changed the title Support $comment update's argument Support comment and $comment update's arguments Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support comment and $comment update's arguments
6 participants