-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support comment
and $comment
update
's arguments
#937
Conversation
Codecov Report
@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 62.00% 62.13% +0.12%
==========================================
Files 228 228
Lines 10597 10610 +13
==========================================
+ Hits 6571 6592 +21
+ Misses 3251 3238 -13
- Partials 775 780 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except naming.
Katerina Bletsch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last tiny correction is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
$comment
update
's argumentcomment
and $comment
update
's arguments
Description
This PR closes #487.
Readiness checklist
task all
, and it passed.task godocs
.