Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build packages on CI #938

Merged
merged 6 commits into from
Jul 25, 2022
Merged

Build packages on CI #938

merged 6 commits into from
Jul 25, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 23, 2022

Description

This PR closes #902.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Jul 23, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 23, 2022
@AlekSi AlekSi added this to the v0.5.1 milestone Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #938 (3e9739d) into main (77e4370) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   60.04%   60.03%   -0.01%     
==========================================
  Files         224      224              
  Lines       10272    10272              
==========================================
- Hits         6168     6167       -1     
+ Misses       3400     3399       -1     
- Partials      704      706       +2     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/databases.go 54.66% <0.00%> (-5.34%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/collections.go 60.17% <0.00%> (+5.30%) ⬆️
Flag Coverage Δ
integration 62.25% <ø> (-0.04%) ⬇️
mongodb 18.90% <ø> (-0.04%) ⬇️
pg 62.15% <ø> (-0.04%) ⬇️
tigris 49.75% <ø> (ø)
unit 24.92% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review July 25, 2022 10:38
@AlekSi AlekSi requested review from a team, w84thesun, seeforschauer and noisersup and removed request for a team July 25, 2022 10:39
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny question.

.github/workflows/packages.yml Show resolved Hide resolved
Taskfile.yml Show resolved Hide resolved
Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit fafa9aa into FerretDB:main Jul 25, 2022
@AlekSi AlekSi deleted the packages branch July 25, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test .rpm and .deb packages on CI
4 participants