Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more scalar values to tests #984

Merged
merged 12 commits into from
Aug 5, 2022
Merged

Add more scalar values to tests #984

merged 12 commits into from
Aug 5, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 3, 2022

Description

Refs #914.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • (for maintainers only) I set Reviewers (@FerretDB/core),
    Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #984 (c630579) into main (df30711) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
+ Coverage   63.64%   63.69%   +0.05%     
==========================================
  Files         234      234              
  Lines       11028    11038      +10     
==========================================
+ Hits         7019     7031      +12     
+ Misses       3182     3180       -2     
  Partials      827      827              
Impacted Files Coverage Δ
integration/shareddata/shareddata.go 81.35% <100.00%> (+3.80%) ⬆️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/common/filter.go 85.38% <0.00%> (ø)
internal/tjson/schema.go 65.04% <0.00%> (+1.62%) ⬆️
internal/handlers/pg/msg_dbstats.go 72.09% <0.00%> (+6.97%) ⬆️
Flag Coverage Δ
integration 59.16% <100.00%> (+0.63%) ⬆️
mongodb 18.20% <100.00%> (+0.05%) ⬆️
pg 61.98% <100.00%> (+0.04%) ⬆️
tigris 25.79% <100.00%> (+1.33%) ⬆️
unit 24.93% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Add int64 to tests Add more scalar values to tests Aug 4, 2022
@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 4, 2022
@AlekSi AlekSi self-assigned this Aug 4, 2022
@AlekSi AlekSi added this to the v0.6.0 milestone Aug 4, 2022
@AlekSi AlekSi marked this pull request as ready for review August 5, 2022 14:13
@AlekSi AlekSi requested a review from a team as a code owner August 5, 2022 14:13
@AlekSi AlekSi requested review from rumyantseva, a team, w84thesun and noisersup and removed request for a team August 5, 2022 14:13
@AlekSi AlekSi enabled auto-merge (squash) August 5, 2022 14:13
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 2512f5d into FerretDB:main Aug 5, 2022
@AlekSi AlekSi deleted the tigris-int64 branch August 5, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants