Projection: excluded and included fields #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2022
AlekSi
reviewed
Mar 22, 2022
AlekSi
reviewed
Mar 22, 2022
AlekSi
reviewed
Mar 22, 2022
tests/ferret/core_test.go
Outdated
| }), | ||
| err: mongo.CommandError{ | ||
| Code: 31253, | ||
| Name: "ErrorCode(31253)", |
There was a problem hiding this comment.
That value is generated from those comments by stringer tool
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
AlekSi
reviewed
Mar 22, 2022
| // o is FindOptions, it's used in projections testing. | ||
| // v is a value and it is also being used in the projections testing, | ||
| // since the resulting value for projection differs from the document value. | ||
| // It's being checked only one of (v, IDs, err). |
There was a problem hiding this comment.
And with inline comments we no longer need that comment
|
hmmm, it didn't fail locally :| |
AlekSi
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FerretDB/FerretDB#377 and FerretDB/FerretDB#382