Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CI #867

Merged
merged 27 commits into from
May 27, 2024
Merged

Simplify CI #867

merged 27 commits into from
May 27, 2024

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented May 6, 2024 •
edited by AlekSi

Closes #866.

@b1ron b1ron self-assigned this May 6, 2024
@b1ron b1ron added the code/chore Dance tool code or tests configuration maintenance improvements label May 6, 2024
@b1ron b1ron marked this pull request as ready for review May 7, 2024 11:57
@b1ron b1ron requested a review from a team as a code owner May 7, 2024 11:57
@b1ron b1ron requested a review from AlekSi May 7, 2024 11:57
@b1ron b1ron enabled auto-merge (squash) May 7, 2024 11:58
AlekSi
AlekSi requested changes May 8, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not remove tests for PLAIN authentication in this issue. It even mentions dotnet-example-plain.sh by name.

@b1ron b1ron requested a review from AlekSi May 9, 2024 09:08
AlekSi
AlekSi requested changes May 14, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#866 says nothing about removing configurations without authentication. We should not do that.

We also should not remove restheart configuration.

Let's focus on doing what the issue says, not other unrelated things.

@AlekSi AlekSi mentioned this pull request May 15, 2024
Closed
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 27, 2024
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label May 27, 2024
@AlekSi AlekSi disabled auto-merge May 27, 2024 16:15
@AlekSi AlekSi merged commit a644501 into FerretDB:main May 27, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees

@b1ron b1ron

Labels
code/chore Dance tool code or tests configuration maintenance improvements
Projects
Current Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify CI setup
2 participants
@b1ron @AlekSi