-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dof distribution slow #632
Comments
I'm sure there are things that could be optimised in the dof distribution, but is ~0.65 s really that slow for a problem with ~9e6 dofs? Wouldn't the assembly or the linear solve be much more likely candidates for a performance bottleneck at that system size? |
Depends on the problem. I have some traveling wave problem where I was able to optimize assembly and solve quite a lot, but my current implementation is capped by the AMR cost (have a quite customized C++ implementation). Reference timings here are (not optimized dof distribution here either):
Ferrite timings are here
^Sorry, copy pasted a wrong function above, which lead to wrong timings. Here is the updated one. |
I would also push back a little bit about calling this "very slow" but yeah, I am sure the performance can be improved. As it is right now the cost is basically completely in dictionary lookups in the part where we check if a dof has already been assigned to a certain entity. |
It is a bit faster now: #643 (comment) |
The current dof distribution algorithm works well, but it is also very slow. This can be a deal-breaker for problems with changing mesh topology of on problems where multiple dof handlers may be used. We should explore different strategies to distribute the dofs faster, (e.g. via fast paths or by using additional information that can be precomputed).
Minimal example is takes from Kim ( #629 )
The text was updated successfully, but these errors were encountered: