Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic Dirichlet boundary conditions #418

Merged
merged 16 commits into from
Feb 17, 2022
Merged

Periodic Dirichlet boundary conditions #418

merged 16 commits into from
Feb 17, 2022

Conversation

fredrikekre
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #418 (6fec127) into master (ea716bc) will decrease coverage by 3.78%.
The diff coverage is 9.58%.

❗ Current head 6fec127 differs from pull request most recent head 16af1f4. Consider uploading reports for the commit 16af1f4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   91.32%   87.53%   -3.79%     
==========================================
  Files          22       22              
  Lines        3043     3177     +134     
==========================================
+ Hits         2779     2781       +2     
- Misses        264      396     +132     
Impacted Files Coverage Δ
src/Dofs/ConstraintHandler.jl 72.51% <9.58%> (-22.14%) ⬇️
src/iterators.jl 96.92% <0.00%> (ø)
src/Dofs/DofHandler.jl 83.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea716bc...16af1f4. Read the comment docs.

Copy link
Collaborator

@lijas lijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some short comment. I did not really check the _add! - function :P

It would also be nice if you can inhomogeneities to the PeriodicConstraint via a function (similarly to how Dirichlet does it). I think you are enforcing [|um|] = 0, but I am enforcing [|u|] = [|uM|]

src/Dofs/ConstraintHandler.jl Show resolved Hide resolved
src/Dofs/ConstraintHandler.jl Show resolved Hide resolved
src/Dofs/ConstraintHandler.jl Show resolved Hide resolved
@fredrikekre fredrikekre changed the title WIP: Strongly periodic Dirichlet boundary conditions WIP: Periodic Dirichlet boundary conditions Feb 11, 2022
@fredrikekre
Copy link
Member Author

It would also be nice if you can inhomogeneities [...]

Done.

@fredrikekre fredrikekre changed the title WIP: Periodic Dirichlet boundary conditions Periodic Dirichlet boundary conditions Feb 16, 2022
Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I had time for now, will continue tomorrow!

docs/src/literate/computational_homogenization.jl Outdated Show resolved Hide resolved
docs/src/literate/computational_homogenization.jl Outdated Show resolved Hide resolved
docs/src/literate/computational_homogenization.jl Outdated Show resolved Hide resolved
Comment on lines +99 to +101
# ``\boldsymbol{u}^\mu`` to be periodic, and ``\boldsymbol{t}`` anti-periodic across the
# RVE. Similarly as for Dirichlet boundary conditions, Eq. ``(1\mathrm{b})`` is directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and \boldsymbol{t} anti-periodic across the RVE"
Is this really true that we enforce, doesn't this just happen to be the case if the structure is periodic?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I believe it is actually just an assumption, but never enforced, which is used to get rid of the second equation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it must hold true for the integral equation due to equilibrium, but I'm not sure about the point-wise anti-periodicity...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2022-02-17 14-31-57
Here are my notes from this -- looks like it is assumed to be pointwise anti-periodic in the derivation, although it is never enforced.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we assume anti-periodicity, and by inserting that assumption in equation 9 it is effectively enforced. Without this assumption, the problem doesn't have sufficient bc because the traction would be unknown for both boundaries. At least that is how it all makes more sense to me now...

Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example!

docs/src/literate/computational_homogenization.jl Outdated Show resolved Hide resolved
docs/src/literate/computational_homogenization.jl Outdated Show resolved Hide resolved
docs/src/literate/computational_homogenization.jl Outdated Show resolved Hide resolved
@fredrikekre fredrikekre merged commit 6c2f525 into master Feb 17, 2022
@fredrikekre fredrikekre deleted the fe/periodic branch February 17, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants