Fix face node ordering for Tetrahedron{3} #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 22 22
Lines 3411 3411
=======================================
Hits 3116 3116
Misses 295 295
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Concerning that this passes tests :D |
|
Where would this cause an issue?We dont have any example that uses the normal, I think. |
|
Add some tests? 🙃 |
This commit fixes the ordering for Ferrite.faces(...) s.t. they are
counter clockwise from the outside. Also adjust the face order for
Lagrange{3,RefCube,2}() to match Lagrange{3,RefCube,1}().
fredrikekre
force-pushed
the
fe/ordering
branch
from
ecb9248
to
22aab9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix face node ordering for Tetrahedron{3} s.t. they are counter clockwise from the outside.