Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default components to constraint to be all components #506

Closed
fredrikekre opened this issue Oct 5, 2022 · 1 comment · Fixed by #509
Closed

Change default components to constraint to be all components #506

fredrikekre opened this issue Oct 5, 2022 · 1 comment · Fixed by #509

Comments

@fredrikekre
Copy link
Member

Currently the default components to constrain in e.g. Dirichlet and PeriodicDirichlet is the first component. It becomes pretty annoying to always have to specify, since you more often than not prescribe them all. For scalar problems "all components" is already the default in a way, but for vector problems it is really strange to default to just the first one.

I suggest that we default to all components instead. One alternative would be to always require the components to be specified explicitly.
@KristofferC
Copy link
Collaborator

Makes sense to me.

fredrikekre added a commit that referenced this issue Oct 6, 2022
@fredrikekre
Default to constraining all components for (Periodic)Dirichlet.
71c23a9 
This patch changes the default components to prescribe for
(Periodic)Dirichlet from component one to all components. This change
does not affect scalar problems, and judging by tests, does not really
affect vector valued problems either since it was already rather strange
to rely on the default behavior of prescribing only the first component.
Fixes #506.
@fredrikekre fredrikekre mentioned this issue Oct 6, 2022
Merged
fredrikekre added a commit that referenced this issue Oct 6, 2022
@fredrikekre
Default to constraining all components for (Periodic)Dirichlet.
5ea42fb 
This patch changes the default components to prescribe for
(Periodic)Dirichlet from component one to all components. This change
does not affect scalar problems, and judging by tests, does not really
affect vector valued problems either since it was already rather strange
to rely on the default behavior of prescribing only the first component.
Fixes #506.
fredrikekre added a commit that referenced this issue Oct 6, 2022
@fredrikekre
Default to constraining all components for (Periodic)Dirichlet.
2fa81a3 
This patch changes the default components to prescribe for
(Periodic)Dirichlet from component one to all components. This change
does not affect scalar problems, and judging by tests, does not really
affect vector valued problems either since it was already rather strange
to rely on the default behavior of prescribing only the first component.
Fixes #506.
fredrikekre added a commit that referenced this issue Oct 6, 2022
@fredrikekre
Default to constraining all components for (Periodic)Dirichlet. (#509)
7c6e055 
This patch changes the default components to prescribe for
(Periodic)Dirichlet from component one to all components. This change
does not affect scalar problems, and judging by tests, does not really
affect vector valued problems either since it was already rather strange
to rely on the default behavior of prescribing only the first component.
Fixes #506.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default to constraining all components for (Periodic)Dirichlet. Ferrite-FEM/Ferrite.jl
2 participants
@KristofferC @fredrikekre