Default to constraining all components for (Periodic)Dirichlet. #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.00% // Head: 91.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 92.00% 91.93% -0.07%
==========================================
Files 22 22
Lines 3703 3709 +6
==========================================
+ Hits 3407 3410 +3
- Misses 296 299 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fredrikekre
force-pushed
the
fe/components
branch
from
71c23a9
to
5ea42fb
Compare
This patch changes the default components to prescribe for (Periodic)Dirichlet from component one to all components. This change does not affect scalar problems, and judging by tests, does not really affect vector valued problems either since it was already rather strange to rely on the default behavior of prescribing only the first component. Fixes #506.
fredrikekre
force-pushed
the
fe/components
branch
from
5ea42fb
to
2fa81a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the default components to prescribe for (Periodic)Dirichlet from component one to all components. This change does not affect scalar problems, and judging by tests, does not really affect vector valued problems either since it was already rather strange to rely on the default behavior of prescribing only the first component. Fixes #506.