-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAE initialization note #604
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aa17e78
Rename file.
f7318c5
Trying to explainthat DAE initialization can be quite problematic.
4aa837a
Try to condense the information and kick out the example.
09a2c79
Move DAE initialization link above note.
c4c5d60
Update docs/src/manual/initial_and_boundary_conditions.md
termi-official cc1a162
Apply suggestions from code review
fredrikekre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
DocTestSetup = :(using Ferrite) | ||
``` | ||
|
||
# Boundary Conditions | ||
# Initial and Boundary Conditions | ||
|
||
Every PDE is accompanied with boundary conditions. There are different types of boundary | ||
conditions, and they need to be handled in different ways. Below we discuss how to handle | ||
|
@@ -256,7 +256,7 @@ pdbc = PeriodicDirichlet( | |
) | ||
``` | ||
|
||
# Initial Conditions | ||
## Initial Conditions | ||
|
||
When solving time-dependent problems, initial conditions, different from zero, may be required. | ||
For finite element formulations of ODE-type, | ||
|
@@ -273,3 +273,9 @@ apply_analytical!(u, dh, :p, x -> ρ * g * x[2]) | |
``` | ||
|
||
See also [Time Dependent Problems](@ref) for one example. | ||
|
||
!!! note "Consistency" | ||
`apply_analytical!` does not enforce consistency of the applied solution with the system of | ||
equations. Some problems, like for example differential-algebraic systems of equations (DAEs) | ||
need extra care during initialization. We refer to the paper ["Consistent Initial Condition Calculation for Differential-Algebraic Systems" by Brown et al.](dx.doi.org/10.1137/S1064827595289996) for more details on this matter. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably you should use the full https URL instead, this gives:
|
||
|
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put this above the note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question here, why would you move it above the note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is easy to miss that reference when reading the docs, but if switched, the note is still hard to miss. And it follows (in my mind) more logically as DAEs are not discussed in that example.