Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dof distribution interface #627

Merged
merged 24 commits into from
May 3, 2023

Conversation

termi-official
Copy link
Member

@termi-official termi-official commented Mar 22, 2023

This enables e.g. order 3 Serendipity and arbitrary order Lagrange in 2D with the MixedDofHandler. Closes #661.

TODOs

  • Basic fix to distribute high order vertex dofs and high order edge dofs
  • Some test coverage
  • Fix mixed tests (faulty semantics?)
  • Devdocs

@fredrikekre fredrikekre added this to the 0.4.0 milestone Mar 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.11 ⚠️

Comparison is base (f923711) 92.90% compared to head (f78f884) 92.79%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   92.90%   92.79%   -0.11%     
==========================================
  Files          30       30              
  Lines        4324     4343      +19     
==========================================
+ Hits         4017     4030      +13     
- Misses        307      313       +6     
Impacted Files Coverage Δ
src/Dofs/DofHandler.jl 92.60% <87.50%> (-1.66%) ⬇️
src/Dofs/ConstraintHandler.jl 95.95% <100.00%> (ø)
src/Grid/grid.jl 91.62% <100.00%> (+0.04%) ⬆️
src/interpolations.jl 98.13% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@termi-official termi-official changed the title RFC: MixedDofHandler high order dof distribution for codimension 1 RFC: Improve dof distribution interface Apr 22, 2023
@termi-official
Copy link
Member Author

termi-official commented Apr 22, 2023

Foundation for the vector wrapper discussed in #676 . I will introduce the interface for the vector stuff in the next PRs. I am still playing around.

@termi-official
Copy link
Member Author

Now, this should contain everything for #676 . I will fix the remaining allocation issue if the interface is okay.

An open issue is to fix the dics used during distribution, as the dof distrubtion currently only works by chance for the implemented interpolations.

@termi-official termi-official marked this pull request as ready for review April 24, 2023 23:39
@termi-official
Copy link
Member Author

This should be almost there. However, there is quite a performance regression (~5%) over master on close! performance, although the total number of allocation is reduced. I tried to track this one down for several hours but could not find why exactly. :/

@termi-official termi-official mentioned this pull request Apr 27, 2023
6 tasks
@termi-official termi-official changed the title RFC: Improve dof distribution interface Improve dof distribution interface Apr 27, 2023
@KnutAM KnutAM mentioned this pull request Apr 27, 2023
@fredrikekre fredrikekre merged commit f03c0d9 into master May 3, 2023
@fredrikekre fredrikekre deleted the do/2d-high-order-mixeddofhandler branch May 3, 2023 08:28
@KnutAM KnutAM mentioned this pull request May 18, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dof management dev-docs
3 participants