Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong confusing order of argument names in shape_x functions #871

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Jan 11, 2024

I messed up the order in #764. Has no influence as both are Ints, but makes it very confusing when reading the code or checking e.g. methods(shape_value)

Ref the docstring:

"""
shape_value(fe_v::AbstractValues, q_point::Int, base_function::Int)
Return the value of shape function `base_function` evaluated in
quadrature point `q_point`.
"""
shape_value(fe_v::AbstractValues, q_point::Int, base_function::Int)

@KnutAM KnutAM merged commit e806ed9 into master Jan 13, 2024
7 checks passed
@KnutAM KnutAM deleted the kam/fix_fevalues_src_typos branch January 13, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant