Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some missing Lagrange docs #889

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update some missing Lagrange docs #889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7bb02e
Update some missing Lagrange docs.
termi-official Mar 1, 2024
b19fad7
Apply suggestions from code review
fredrikekre Mar 4, 2024
c98c9f4
Merge branch 'master' into do/update-missing-some-lagrange-docs
termi-official Jun 3, 2024
5622856
Change something. Broke everything.
termi-official Jun 3, 2024
ac5f104
Add some missing docs and update the example in the topics.
termi-official Jun 3, 2024
1cd9a82
Apply Knuts suggestions.
termi-official Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/src/topics/degrees_of_freedom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ need to specify number of components for the field. Here we add a vector field `
(2 components for a 2D problem) and a scalar field `:p`.

```@example dofs
add!(dh, :u, Lagrange{2,RefTetrahedron,1}()^2)
add!(dh, :p, Lagrange{2,RefTetrahedron,1}())
add!(dh, :u, Lagrange{RefTriangle,1}()^2)
add!(dh, :p, Lagrange{RefTriangle,1}())
fredrikekre marked this conversation as resolved.
Show resolved Hide resolved
# hide
```

Expand All @@ -53,8 +53,8 @@ quadratic interpolation, and our `:p` field with a linear approximation.

```@example dofs
dh = DofHandler(grid) # hide
add!(dh, :u, Lagrange{2,RefTetrahedron,2}()^2)
add!(dh, :p, Lagrange{2,RefTetrahedron,1}())
add!(dh, :u, Lagrange{RefTriangle,2}()^2)
add!(dh, :p, Lagrange{RefTriangle,1}())
fredrikekre marked this conversation as resolved.
Show resolved Hide resolved
# hide
```

Expand Down
4 changes: 2 additions & 2 deletions docs/src/topics/grid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ In this space a local numbering of nodes and faces exists, i.e.
The example shows a local face ID ordering, defined as:

```julia
faces(::Lagrange{2,RefCube,1}) = ((1,2), (2,3), (3,4), (4,1))
faces(::Lagrange{RefQuadrilateral,1}) = ((1,2), (2,3), (3,4), (4,1))
fredrikekre marked this conversation as resolved.
Show resolved Hide resolved
```

Other face ID definitions [can be found in the src files](https://github.com/Ferrite-FEM/Ferrite.jl/blob/8224282ab4d67cb523ef342e4a6ceb1716764ada/src/interpolations.jl#L154) in the corresponding `faces` dispatch.
termi-official marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -123,7 +123,7 @@ julia> function compute_faceset(cells, global_faces, ip::Interpolation{dim}) whe
return faces
end

julia> interpolation = Lagrange{2, RefCube, 1}()
julia> interpolation = Lagrange{RefQuadrilateral, 1}()

julia> compute_faceset(cells, faces, interpolation)
Vector{FaceIndex} with 2 elements:
Expand Down