transfer solution optimization #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termi-official
requested changes
Mar 13, 2023
src/utils.jl
Outdated
| @@ -300,7 +300,7 @@ midpoint(cell::Ferrite.AbstractCell{3,N,6}, points) where N = Point3f(0.5 * (poi | |||
| function postprocess(node_values) | |||
| dim = length(node_values) | |||
| if dim == 1 | |||
| return node_values | |||
| return node_values[1] | |||
There was a problem hiding this comment.
Can you quickly leave a comment why this is here (for future generations to not delete it :))
There was a problem hiding this comment.
here or in the source code?
The function was inherently type unstable because if the dimension of the input is 1 it returned a vector of length 1 and in all other cases it reduced the vector entries to a scalar value
There was a problem hiding this comment.
In the source code (e.g. for contributors seeing this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transfer_solutionassociated withip_field::InterpolationFerriteViz.postprocesstype stableThe internal "kernel" for the transfer
_transfer_solutionis close to type grounded