Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MixedDofhandler support #70

Merged
merged 34 commits into from May 24, 2023
Merged

MixedDofhandler support #70

merged 34 commits into from May 24, 2023

Conversation

koehlerson
Copy link
Member

@koehlerson koehlerson commented Mar 20, 2023

New features

  • every plottype works with deformation field for the MixedDofHandler
  • deformation field can be a "subdomain" field as well
  • fields on subdomains are only displayed on the subdomain (implemented by initializing the transfer to NaN)
  • introduces a little overhead compared to the previous implementation, benchmark are still todo
  • docs/src/ferrite-examples/mixedgrid.jl example which requires FerriteGmsh

Requirements

  • Ferrite.jl 0.3.13, so docs currently don't work, they pull the latest release constrained the Ferrite version to latest release

Future changes

@koehlerson
Copy link
Member Author

should we merge this and bump a version @termi-official before the dofhandlers are merged?

Copy link
Member

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should. I left a suggestion to make the PR non-breaking for users.

src/makieplotting.jl Outdated Show resolved Hide resolved
@koehlerson
Copy link
Member Author

for some reason the docs only show the first figure of a page, don't know what's going wrong there

@termi-official
Copy link
Member

termi-official commented Apr 21, 2023

Regression in WGLMakie or compat issue maybe? I quickly looked into this and could not find anything suspicious. You could also try to give the examples different numbers. Maybe the regression hides there.

Edit: https://github.com/Ferrite-FEM/FerriteViz.jl/blob/master/docs/Manifest.toml#L1305 we can try to just update WGLMakie.jl

@koehlerson
Copy link
Member Author

besides WGLMakie bug ok?

@termi-official
Copy link
Member

Yes. But I can reproduce the problem locally on my machine across different WGLMakie versions. Plotting the figures individually with WGLMakie works tho.

@koehlerson
Copy link
Member Author

I guess it's more of a JSServe issue then

@termi-official
Copy link
Member

Maybe. I am more wondering why this one is completely silent. I could not find any error message or warning related t this in neither the browser console, nor the terminal. Maybe bisect which commit causes the issue?

We should also think about a way to capture this automatically in CI, so we can react earlier.

@koehlerson
Copy link
Member Author

We can't do more than #71 If JSServe fails silently we can't do much about it

@termi-official
Copy link
Member

We should be able to check somehow if any of the plot panels in the html is empty. Not straight forward tho.

docs/src/atopics.md Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@termi-official termi-official self-requested a review May 23, 2023 14:59
Copy link
Member

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to JSServe 2.2.3 works locally with the current state. So we just have to wait for the register to finish and can finally merge. Thanks Maxi (and Simon)!

@koehlerson koehlerson merged commit b1cede0 into master May 24, 2023
6 checks passed
@koehlerson koehlerson deleted the mk/mixeddofhandler branch May 24, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants