Allow param reassignment in compact constructor

Feuermagier · Apr 8, 2024 · 6e21a35 · 6e21a35
1 parent 36ee212
commit 6e21a35
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/...ore/src/main/java/de/firemage/autograder/core/check/general/ReassignedParameterCheck.java b/...ore/src/main/java/de/firemage/autograder/core/check/general/ReassignedParameterCheck.java
@@ -8,6 +8,7 @@
 import de.firemage.autograder.core.integrated.SpoonUtil;
 import de.firemage.autograder.core.integrated.StaticAnalysis;
 import spoon.processing.AbstractProcessor;
+import spoon.reflect.declaration.CtConstructor;
 import spoon.reflect.declaration.CtParameter;
 
 import java.util.Map;
@@ -19,7 +20,10 @@ protected void check(StaticAnalysis staticAnalysis, DynamicAnalysis dynamicAnaly
         staticAnalysis.processWith(new AbstractProcessor<CtParameter<?>>() {
             @Override
             public void process(CtParameter<?> ctParameter) {
-                if (ctParameter.isImplicit() || !ctParameter.getPosition().isValidPosition()) {
+                if (ctParameter.isImplicit()
+                    || !ctParameter.getPosition().isValidPosition()
+                    // reassignment in compact constructor is used to modify the future record field value
+                    || (ctParameter.getParent() instanceof CtConstructor<?> ctor && ctor.isCompactConstructor())) {
                     return;
                 }
 

diff --git a/...src/test/java/de/firemage/autograder/core/check/general/TestReassignedParameterCheck.java b/...src/test/java/de/firemage/autograder/core/check/general/TestReassignedParameterCheck.java
@@ -81,6 +81,29 @@ class Test<T> {
         problems.assertExhausted();
     }
 
+    @Test
+    void testRecordConstructor() throws IOException, LinterException {
+        ProblemIterator problems = this.checkIterator(StringSourceInfo.fromSourceString(
+            JavaVersion.JAVA_17,
+            "Test",
+            """
+                record Test(int a) {
+                    Test {
+                        a = 1; //# ok
+                    }
+
+                    Test(int a, int b) {
+                        this(a);
+                        b = 3; //# not ok
+                    }
+                }
+                """
+        ), PROBLEM_TYPES);
+
+        assertEqualsReassigned(problems.next(), "b");
+        problems.assertExhausted();
+    }
+
     @Test
     void testLambda() throws IOException, LinterException {
         ProblemIterator problems = this.checkIterator(StringSourceInfo.fromSourceString(