skip default case in throws documented check #489

Feuermagier · May 16, 2024 · 97adfa6 · 97adfa6
1 parent 2b15e2c
commit 97adfa6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/...ader-core/src/main/java/de/firemage/autograder/core/check/comment/ThrowsJavadocCheck.java b/...ader-core/src/main/java/de/firemage/autograder/core/check/comment/ThrowsJavadocCheck.java
@@ -6,6 +6,8 @@
 import de.firemage.autograder.core.integrated.IntegratedCheck;
 import de.firemage.autograder.core.integrated.SpoonUtil;
 import de.firemage.autograder.core.integrated.StaticAnalysis;
+import spoon.reflect.code.CtAbstractSwitch;
+import spoon.reflect.code.CtCase;
 import spoon.reflect.code.CtConstructorCall;
 import spoon.reflect.code.CtJavaDoc;
 import spoon.reflect.code.CtJavaDocTag;
@@ -39,6 +41,12 @@ private void checkCtExecutable(CtExecutable<?> ctExecutable) {
         List<CtThrow> ctThrows = ctExecutable.filterChildren(CtThrow.class::isInstance)
                 .map(CtThrow.class::cast).list();
         for (CtThrow ctThrow : ctThrows) {
+            CtCase<?> ctParentCase = ctThrow.getParent(CtCase.class);
+            // skip default cases in switch statements
+            if (ctParentCase != null && ctParentCase.getCaseExpressions().isEmpty()) {
+                continue;
+            }
+
             if (ctThrow.getThrownExpression() instanceof CtConstructorCall<?> ctConstructorCall) {
                 String name = ctConstructorCall.getType().getSimpleName();
 

diff --git a/.../test/resources/de/firemage/autograder/core/check_tests/ThrowsJavadocCheck/code/Test.java b/.../test/resources/de/firemage/autograder/core/check_tests/ThrowsJavadocCheck/code/Test.java
@@ -52,4 +52,17 @@ private static void b() {
     public static void c() {
         throw new IllegalArgumentException("Error"); /*# ok #*/
     }
+
+    /**
+     * Does some things
+     */
+    public static void doesSomething(String foo) {
+        switch (foo) {
+            case "a":
+                System.out.println("a");
+                break;
+            default:
+                throw new IllegalArgumentException("Error"); /*# ok #*/
+        }
+    }
 }