Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect when a class implements Comparator with itself: class A implements Comparator<A> #425

Closed
Luro02 opened this issue Feb 8, 2024 · 0 comments · Fixed by #427
Closed

Detect when a class implements Comparator with itself: class A implements Comparator<A> #425

Luro02 opened this issue Feb 8, 2024 · 0 comments · Fixed by #427
Labels
bug Something isn't working false-negative A lint should trigger on code that is wrong.
Milestone
v0.5.30

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Feb 8, 2024

Description

This is redundant, instead Comparable should be implemented
@Luro02 Luro02 added bug Something isn't working false-negative A lint should trigger on code that is wrong. labels Feb 8, 2024
@Luro02 Luro02 modified the milestones: v0.6, v0.6.0, v0.5.30 Feb 18, 2024
Luro02 added a commit to Luro02/autograder that referenced this issue Mar 18, 2024
@Luro02
rewrite comparator check Feuermagier#425 Feuermagier#430
a1cfba1
@Luro02 Luro02 mentioned this issue Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working false-negative A lint should trigger on code that is wrong.
Projects
None yet
Milestone
v0.5.30
Development

Successfully merging a pull request may close this issue.

Implement some things Luro02/autograder
1 participant
@Luro02