Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO/UI should be relaxed to only trigger when the output is not in one package #433

Closed
Luro02 opened this issue Feb 13, 2024 · 0 comments · Fixed by #427
Closed

IO/UI should be relaxed to only trigger when the output is not in one package #433

Luro02 opened this issue Feb 13, 2024 · 0 comments · Fixed by #427
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Milestone

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Feb 13, 2024

Summary

Currently it checks that everything is in a single class. This is too strict for projects with many packages and classes, where one may have an output in multiple command classes.

In early submissions where there is not a lot of code (everything in one package), we could keep the current behaviour.

TODO: When the project looks like this:

edu.kit.informatik
| Main
| model
  | ...
| ui
  | commands
    | QuitCommand
    | AddCommand
  | extras
    | SomeHelper
  | UserInterface

It should be okay to have all the IO in the ui package and it's "subpackages".

Lint Name

No response

Reproducer

<code>
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels Feb 13, 2024
@Luro02 Luro02 modified the milestones: v0.6, v0.6.0, v0.5.30 Feb 18, 2024
Luro02 added a commit to Luro02/autograder that referenced this issue Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant