Feature/add linting #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor Dockerfile - Refactor makefile - Update pipfile - Update pipfile.lock - create .flake8 file - create pyproject.toml - update test.yml from github actions - remove python 3.7 support - add python 3.9 support
- Update github actions
- Reformated
lpl
reviewed
May 25, 2023
.github/workflows/test.yml
Outdated
| @@ -7,7 +7,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: [ '3.7', '3.8' ] | |||
| python-version: [ '3.8', '3.9' ] | |||
There was a problem hiding this comment.
I'd add 3.10 and 3.11 if no adjustments are needed
lpl
reviewed
May 25, 2023
lpl
reviewed
May 25, 2023
pyproject.toml
Outdated
| ''' | ||
|
|
||
| [tool.mypy] | ||
| ignore_missing_imports = true |
There was a problem hiding this comment.
This is dangerous, it won't follow imports when scanning if it cannot find it. In the past (and I think that also currently in some other projects) we had serious troubles with typing correctness because we initially set this to true.
I suggest you to remove this line and check if we can easily (30m max) fix the typing problems that appear. If it's too much effort, let's add a comment for the future reader showing that this line should be changed.
There was a problem hiding this comment.
There was a problem hiding this comment.
will check.
Note: this lines are also in other projects, we may also investigate it
- Add python version on github actions
- Move from pipenv to poetry - Remove unused_imports from mypy options - Upgrade 3.8
- Add poetry lock
# Conflicts: # setup.py # src/pypendency/exceptions.py
- Lint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Linting to the project
Linting has been added to improve the development experience.
Important
Testing for Python 3.7 has been removed as official support ends on June 2023
Testing for Python 3.9 has been added