PLATFORM-1762 Create get_services_identifiers_by_tag_name method at container #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemo-fever
requested review from
gprossignoli
and removed request for
a team and
Guille-Barrena
src/pypendency/container.py
Outdated
| @@ -149,5 +125,43 @@ def __instance_from_fqn(self, fully_qualified_name: str, args: list, kwargs: dic | |||
| except TypeError as e: | |||
| raise exceptions.ServiceInstantiationFailed(fully_qualified_name) from e | |||
|
|
|||
| def has(self, identifier: str) -> bool: | |||
| return identifier in self._service_mapping | |||
| def get_service_identifier(self, service: Union[object, Definition]) -> str: | |||
There was a problem hiding this comment.
So this isn't new, it was moved, right?
There was a problem hiding this comment.
has was moved, and get_service_identifier is the only new method i created
jorgemo-fever
changed the title
gprossignoli
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLATFORM-1762
Description
Tags would get advantage of this functionality and it is needed for implementing it at Transactional API.
How to test