Memory leak #744
Closed
Memory leak #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2019
Closed
|
friendly ping @FezVrasta 😄 |
|
CodeClimate checks are failing (there's a lot of code repetition in this PR). If anyone wants to adopt the PR, fix the CodeClimate errors, and maybe add a test to make sure the fix works, I'll happily merge it. |
|
@FezVrasta Understand, those are valid points! Awesome work you've done on popper, it's a beautiful library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a memory leak happening because the
mousedownevent on document never gets cleared for each popper. This fixes it.