Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test including large constraint query to test translation layer for GQL/REST APIs #317

Closed
lukashornych opened this issue Nov 7, 2023 · 1 comment · Fixed by #620
Assignees
Labels
enhancement New feature or request

Comments

@lukashornych
Copy link
Collaborator

Currently, we test the translation layer from JSON query to Java query tree in:

evita_functional_tests/src/test/java/io/evitadb/externalApi/graphql/api/catalog/dataApi/resolver/constraint

but this tests only basic rules of translation, but it doesn't test if all constraint can be translated in expected form to the Java variant.

This kind of test already exists in the evitaDB C# client where also need to verify that we can translate all constraints.

Therefore, new test should be created for the translation layer where query with all constraint will be tested if it can be translated without error into expected Java query. This query doesn't need to return any data.

@lukashornych lukashornych self-assigned this Nov 7, 2023
@lukashornych lukashornych added the enhancement New feature or request label Nov 7, 2023
@lukashornych
Copy link
Collaborator Author

We could use the #318 here as well to keep the test up to date.

lukashornych added a commit that referenced this issue Jun 25, 2024
…e-constraint-query-to-test-translation-layer-for-gqlrest-apis

test(#317): add tests for testing large query in GQL and REST APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant