Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log exception to message in JSON layout #534

Closed
lukashornych opened this issue Apr 24, 2024 · 0 comments · Fixed by #535
Closed

Log exception to message in JSON layout #534

lukashornych opened this issue Apr 24, 2024 · 0 comments · Fixed by #535
Assignees
@lukashornych
Labels
enhancement New feature or request

Comments

@lukashornych
Copy link
Collaborator

Currently, we log stacktrace of exception to separate JSON field "throwableProxy" when JSON layout is used. But Loki that consumes these objects cannot properly render multiline text in structured metadata. That's why we will append the stacktrace to the main error message just like the default Logback layout does.
@lukashornych lukashornych self-assigned this Apr 24, 2024
@lukashornych lukashornych added the enhancement New feature or request label Apr 24, 2024
lukashornych added a commit that referenced this issue Apr 24, 2024
@lukashornych
fix(#534): log exception with log message so that consumers can bette…
9eb443e 
…r work with the multiline text inside
lukashornych added a commit that referenced this issue Apr 24, 2024
@lukashornych
Revert "fix(#534): log exception with log message so that consumers c…
c23d7d0 
…an better work with the multiline text inside"

This reverts commit 9eb443e.
lukashornych added a commit that referenced this issue Apr 24, 2024
@lukashornych
ix(#534): log exception with log message so that consumers can better…
36874d7 
… work with the multiline text inside
@lukashornych lukashornych linked a pull request Apr 24, 2024 that will close this issue
fix(#534): log exception with log message so that consumers can better work with the multiline text inside #535
Merged
lukashornych added a commit that referenced this issue Apr 24, 2024
@lukashornych
Merge pull request #535 from FgForrest/534-log-exception-to-message-i…
abfbc15 
…n-json-layout

 fix(#534): log exception with log message so that consumers can better work with the multiline text inside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukashornych lukashornych

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@lukashornych