Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity fetching optimization #559

Closed
novoj opened this issue May 10, 2024 · 0 comments · Fixed by #560
Closed

Entity fetching optimization #559

novoj opened this issue May 10, 2024 · 0 comments · Fixed by #560
Assignees
Labels
performance Performance problem.
Milestone

Comments

@novoj
Copy link
Collaborator

novoj commented May 10, 2024

When the entity is fetched from the data store, it's entity body storage part is always fetched twice. This becomes a problem when a large number of entities are fetched from the data store, and when the OS file cache is cold, it can mean twice the latency. This fetching is not entirely necessary if we refactor the enrichEntity method into two separate ones and call the second one only conditionally.

@novoj novoj added the performance Performance problem. label May 10, 2024
@novoj novoj added this to the Beta milestone May 10, 2024
@novoj novoj self-assigned this May 10, 2024
novoj added a commit that referenced this issue May 10, 2024
When the entity is fetched from the data store, it's entity body storage part is always fetched twice. This becomes a problem when a large number of entities are fetched from the data store, and when the OS file cache is cold, it can mean twice the latency. This fetching is not entirely necessary if we refactor the `enrichEntity` method into two separate ones and call the second one only conditionally.
@novoj novoj linked a pull request May 10, 2024 that will close this issue
novoj added a commit that referenced this issue May 10, 2024
novoj added a commit that referenced this issue May 11, 2024
Fixes revealed by documentation tests. Entities used wrong predicates when prefetched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance problem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant