fix(#537): Incorrect facet statistics difference when userFilter is used #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When UserFilterFormula was not part of the computational tree, the facet impact computation didn't work well. Also the calculation of the best query plan tree was inverse and that was corrected as well. Finally the pretty printing visitor got split in normal and verbose mode. The normal mode is much more comprehensible when debugging larger trees.
novoj
deleted the
537-incorrect-facet-statistics-difference-when-userfilter-is-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UserFilterFormula was not part of the computational tree, the facet impact computation didn't work well. Also the calculation of the best query plan tree was inverse and that was corrected as well. Finally the pretty printing visitor got split in normal and verbose mode. The normal mode is much more comprehensible when debugging larger trees.