Purge menu cache while creation/editing and various version state changes #38
Conversation
webbyfox
changed the title
webbyfox
changed the title
| # Now publish the page content containing the plugin, | ||
| # so the page can be viewed | ||
| version = page_content.versions.get() | ||
| version.publish(self.get_superuser()) |
There was a problem hiding this comment.
Actually, now seeing this simplified version of the test, I think you can simplify further. Possibly you can create the page content as published straight away? As in page_content = factories.PageContentWithVersionFactory(language=self.language, version__created_by=self.get_superuser(), version__state=PUBLISHED) above. Then you don't need these two lines at all.
There was a problem hiding this comment.
Not sure you can add a placeholder(and plugin) to the published page.
There was a problem hiding this comment.
I don't think you're modifying the page after this line
| cache_key = CacheKey.objects.all().count() | ||
| self.assertEqual(cache_key, 1) | ||
|
|
||
| self.assertEqual(response.status_code, 200) |
There was a problem hiding this comment.
Comment these asserts so it's clear what and why you're checking.
There was a problem hiding this comment.
Not sure this assert needs any comment.
tests/test_plugin.py
Outdated
| self.assertIn(child.title, str(response.content)) | ||
| self.assertIn(grandchild.title, str(response.content)) | ||
|
|
||
| # Create further menu items which covers draft state |
There was a problem hiding this comment.
What does "covers draft state" mean? And why does the draft state matter in this test? I thought this line was here simply because you want to check that when the menu version is modified, the cache clearing fires up?
tests/test_plugin.py
Outdated
| @@ -261,3 +263,186 @@ def test_crud_for_navigation_plugin_when_versioning_disabled(self): | |||
|
|
|||
| # Now delete the plugin from the page and assert | |||
| self._delete_nav_plugin_and_assert(new_placeholder, new_plugin) | |||
|
|
|||
| def test_menu_cache_invalidate_after_menuitem_creation(self): | |||
There was a problem hiding this comment.
I think this is actually a test for whether the cache is invalidated after edit rather than after creation, right?
tests/test_plugin.py
Outdated
| child2 = factories.ChildMenuItemFactory(parent=menu_content.root) | ||
|
|
||
| # grandchild2 | ||
| factories.ChildMenuItemFactory(parent=child2) |
There was a problem hiding this comment.
Tbh, I think you only need one of these two lines.
| # Add nav plugin to placeholder | ||
| self._add_nav_plugin_and_assert( | ||
| placeholder, menu_content.menu, "menu/menu.html" | ||
| ) |
There was a problem hiding this comment.
As above, ditto on TODO comment (and same for tests below)
| # Now publish the page content containing the plugin, | ||
| # so the page can be viewed | ||
| version = page_content.versions.get() | ||
| version.publish(self.get_superuser()) |
There was a problem hiding this comment.
As above, you probably won't need this if you just set this version to published straight away (and ditto for tests below).
tests/test_plugin.py
Outdated
| page_url = page_content.page.get_absolute_url() | ||
| response = self.client.get(page_url) | ||
|
|
||
| # Rendering should generate cachekey object |
There was a problem hiding this comment.
This confused me, I thought you'd missed an intended assert, but then realized the comment actually describes an assert that is 4 lines down. So you might want to fix the line spacing/position of the comment/asserts here.
tests/test_plugin.py
Outdated
| page_url = page_content.page.get_absolute_url() | ||
| response = self.client.get(page_url) | ||
|
|
||
| # Rendering should generate cachekey object |
There was a problem hiding this comment.
Ditto on strange line spacing/comment not describing the block of code it's attached to.
No description provided.