Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised the launch file example in README.md documentation #20

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

robograffitti
Copy link
Contributor

@robograffitti robograffitti commented Jun 28, 2022

I updated the README.md document file.

Without setting the paremter "frame_id", the node does not publish /velodyne_points topic.

The topic coming from Unity /velodyne_packets contains frame_id: velodyne, but velodyne transform node set frame_id: odom as default. This consistency makes an error of not publishing the velodyne point cloud topic.

@robograffitti
Copy link
Contributor Author

related to #17

Copy link
Member

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the update, and it works.
I will merge it.

@RyodoTanaka
Copy link
Member

We should update the CI test with Unity 2020.3.x LTS version.
In any way, this PR does not change the source code itself.
So, I will merge it ignoring the CI / Test error.

@RyodoTanaka RyodoTanaka merged commit 7084e36 into Field-Robotics-Japan:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants