Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization #90

Merged
merged 115 commits into from
Jan 11, 2024
Merged

Optimization #90

merged 115 commits into from
Jan 11, 2024

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Jan 5, 2024

変更点

  • 名前空間の細分化
  • Visualizerクラスをイベントドリブンなものに変更(センサー更新時のコールバック機能を追加)
  • Serializerクラスが直接Sensorクラスにアクセスできるように変更
    従来はPublisherクラスがSensor-Serializer間のデータの受け渡しを行っていた
  • Serializer, PublisherクラスはSensorに対してではなく、扱うメッセージの型に対して作られるように再設計
    これにより、DepthCameraとLiDARの間で点群メッセージのSerializer, Publisherを共通化した
  • 点群の可視化をGPUインスタンスを用いて高速化した
  • LiDARのスキャンパターン生成機能を、ScanPatternオブジェクトから分離しScanPatternGeneratorとして実装した
  • Raycast,DepthBufferの2手法それぞれについて、全てのLiDARスキャンパターンに対応した
  • 以下のLiDARのスキャンパターンを追加した
    • Velodyne VLS-128(ALPHA PRIME)
    • Livox Mid-360
    • Livox HAP

Changes Overview

  • Namespace Refactoring

  • Modified "Visualizer" classes to operate in event-driven

  • Modified "Serializer" classes to have direct access to each "Sensor" class

  • Modified "Serializer", "Publisher" classes to correspond to the type of message they handled, not to the sensor

  • Accelerated visualization of point clouds using GPU instances

  • Added "ScanPatternGenerator" class to generate "ScanPattern" scriptable object

  • DepthBuffer method now available for all scan patterns
    Now VLS-128 runs at 60 FPS 😎
    image

  • The following LiDAR scan patterns were added

    • Velodyne VLS-128(ALPHA PRIME)
    • Livox Mid-360
    • Livox HAP

image

@RyodoTanaka RyodoTanaka self-requested a review January 10, 2024 05:25
Copy link
Member

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the update.
And confirmed all scripts are working.
So, I approve this PR.

@RyodoTanaka RyodoTanaka merged commit da5bec6 into develop Jan 11, 2024
1 check passed
@RyodoTanaka RyodoTanaka deleted the dev/restruct branch January 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants