-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/swath discretization #93
Feature/swath discretization #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Marnonel6, cool PR!! Thank you for your contribution. I have left a few comments to solve a few issues I've seen. Thank you again
I'll get on those comments thank you! |
Updated some of the mentioned comments. Let me know what you think and what should still change @Gonzalo-Mier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I've updated your latest comments and added a bunch of tests. Let me know what you think @Gonzalo-Mier . |
Thank your really much. Just for the record, I made a few changes. I changed the style of the code to be in the same style as the rest of the repo (2 spaces instead of 4 and { in the same line as for() and if()). Moreover, I moved the test from the path_planning to the Path_test. |
My pleasure. Thank you for the merge! |
Description:
This PR introduces a new feature in our Path Planning module which discretizes swath sections of the path. By providing a discretization step and the robot's swath speed, the function returns a new path with the swath sections discretized.
Main Changes:
Swath Discretization Function:
Path::discretize_swath(double step_size, double swath_speed)
that takes in astep_size
andswath_speed
and returns a new path with discretized swath sections.Example Script:
discretize_swath_path.cpp
demonstrates the use of thediscretize_swath
function.discretize_swath
function to generate a discretized path and visualize it using our visualization module.Tests:
Screenshots & Files
discretized_swath_path.csv