Allow the Thief Lockpicking to be granted by a Blursing #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponding bonus. Everything except the assembler changes.
…en attempting to open a door
…door we have to give the Thief and Ninja that bonus unless we are in "Blursed" mode
…d a hardcoded class check. We can apply the blursing to any class(es) we wish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a superset of #977 which turns the "Thief Lockpicking" checkbox into a select list with the options "None" (same as unchecked before), "Thief" (same as checked before), and "Blessed Thief Only" (adds a bonus to the pool which can be applied to Thief. If present, it grants the lockpicking ability). If this is merged then #977 should be closed, as it will have been superseded.
Because of how I structured this we could easily allow any class to pick locks simply by adding it to the list of classes which can obtain this bonus.
I built the application, deployed locally, and tested various scenarios (no Thief, Thief but in None mode, Thief with no bonus in Blursing mode, and Thief with bonus in Blursing mode).
Everything matches my expectations, and all behavior appears to be correct.
I welcome all comments, feedback, and corrections. This is the first time I've done any 6502 programming.
This impacts #964 which I think gets easier to implement if this is merged first.