Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding universal attributes to all components (excluding term) #379

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Adding universal attributes to all components (excluding term) #379

merged 6 commits into from
Aug 30, 2022

Conversation

Heulitig
Copy link
Contributor

@Heulitig Heulitig commented Aug 25, 2022 •
edited
Loading

  • added universal attributes to all components (id, top, align etc.)
    Doc PR
  • added check for redundant declaration of universal attribute by the user on components
  • fixed all ftd tests after these changes
  • example test file added universal-attributes.ftd
  • tested on the mentioned code
-- ftd.text foo: $id

-- foo:
id: hello
  • This is a continuation of an Old PR

The idea of using terms for linking is dropped. Global id will be used for linking now
Refer discussion

@Heulitig Heulitig requested a review from amitu August 25, 2022 08:17
@Heulitig Heulitig mentioned this pull request Aug 25, 2022
Closed
9 tasks
@Heulitig
Copy link
Contributor Author

@Arpita-Jaiswal I'm done with this PR can you pls review it ?

@Arpita-Jaiswal Arpita-Jaiswal merged commit 9dff90d into main Aug 30, 2022
@Arpita-Jaiswal Arpita-Jaiswal deleted the adding-universal-attributes-to-all-components branch August 30, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitu amitu Awaiting requested review from amitu

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Heulitig @Arpita-Jaiswal