Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Story 7.1 / 7.2 - Application Page #2362

Merged
merged 19 commits into from
May 19, 2021

Conversation

xJamesScott
Copy link
Collaborator

What does this pull request aim to achieve? 馃挴

Please be concise and link any related issue(s):

  • I have checked that no one else is working on similar changes.
  • I have read the latest README and understand the development workflow.
  • The name of this branch is: feature/<branch_name> for a regular feature, hotfix/<branch_name> for a hotfix, and service/<branch_name> for a microservice, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
  • This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
  • There are no merge conflicts.
  • There are no console warnings and errors.
  • On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
  • The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

@todo
Copy link

todo bot commented May 7, 2021

- change authenticateOptional to authenticate

// TODO - change authenticateOptional to authenticate
preValidation: [app.authenticateOptional],
schema: updateApplicantStatusSchema
},
async (req) => {
const {


This comment was generated by todo based on a TODO comment in 21dea90 in #2362. cc @FightPandemics.

@todo
Copy link

todo bot commented May 7, 2021

Send to applicants page

// TODO Send to applicants page
// to={}
>
<PositionsButton
>
{t("positions.okay")}


This comment was generated by todo based on a TODO comment in 21dea90 in #2362. cc @FightPandemics.

@xJamesScott xJamesScott merged commit a0e6cb2 into feature/join-org May 19, 2021
@xJamesScott xJamesScott deleted the feature/join-org-US7.1 branch May 19, 2021 18:43
@todo todo bot mentioned this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Story 7.2 - Application Page, Org Owner/Admin User Story 7.1 - Application Page, Org Owner/Admin
1 participant