Fixes:

Vector Operator *: Multiplying by a Matrix modifies the vector instead of copying it. EntityNameplate:getBackgroundColor(): Returns a barg vector instead of an rgba vector.
FiguraMC · Sep 17, 2023 · b9ddd1e · b9ddd1e
1 parent 6d9b152
commit b9ddd1e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/common/src/main/java/org/figuramc/figura/lua/api/nameplate/EntityNameplateCustomization.java b/common/src/main/java/org/figuramc/figura/lua/api/nameplate/EntityNameplateCustomization.java
@@ -121,7 +121,7 @@ public EntityNameplateCustomization scale(Object x, Double y, Double z) {
     @LuaWhitelist
     @LuaMethodDoc("nameplate_entity.get_background_color")
     public FiguraVec4 getBackgroundColor() {
-        return this.background == null ? null : ColorUtils.intToARGB(this.background);
+        return this.background == null ? null : ColorUtils.intToRGBA(this.background);
     }
 
     @LuaWhitelist
@@ -141,7 +141,7 @@ public FiguraVec4 getBackgroundColor() {
     )
     public EntityNameplateCustomization setBackgroundColor(Object r, Double g, Double b, Double a) {
         FiguraVec4 vec = LuaUtils.parseVec4("setBackgroundColor", r, g, b, a, 0, 0, 0,  Minecraft.getInstance().options.getBackgroundOpacity(0.25f));
-        this.background = ColorUtils.rgbaToIntARGB(vec);
+        this.background = ColorUtils.rgbaToInt(vec);
         return this;
     }
 

diff --git a/common/src/main/java/org/figuramc/figura/math/vector/FiguraVec2.java b/common/src/main/java/org/figuramc/figura/math/vector/FiguraVec2.java
@@ -548,7 +548,7 @@ public static FiguraVec2 __mul(@LuaNotNil Object a, @LuaNotNil Object b) {
             else if (b instanceof Number d)
                 return vec.scaled(d.doubleValue());
             else if (b instanceof FiguraMat2 mat)
-                return vec.transform(mat);
+                return vec.copy().transform(mat);
         } else if (a instanceof Number d && b instanceof FiguraVec2 vec) {
             return (vec.scaled(d.doubleValue()));
         }

diff --git a/common/src/main/java/org/figuramc/figura/math/vector/FiguraVec3.java b/common/src/main/java/org/figuramc/figura/math/vector/FiguraVec3.java
@@ -621,7 +621,7 @@ public static FiguraVec3 __mul(@LuaNotNil Object a, @LuaNotNil Object b) {
             else if (b instanceof Number d)
                 return vec.scaled(d.doubleValue());
             else if (b instanceof FiguraMat3 mat)
-                return vec.transform(mat);
+                return vec.copy().transform(mat);
         } else if (a instanceof Number d && b instanceof FiguraVec3 vec) {
             return (vec.scaled(d.doubleValue()));
         }

diff --git a/common/src/main/java/org/figuramc/figura/math/vector/FiguraVec4.java b/common/src/main/java/org/figuramc/figura/math/vector/FiguraVec4.java
@@ -588,7 +588,7 @@ public static FiguraVec4 __mul(@LuaNotNil Object a, @LuaNotNil Object b) {
             else if (b instanceof Number d)
                 return vec.scaled(d.doubleValue());
             else if (b instanceof FiguraMat4 mat)
-                return vec.transform(mat);
+                return vec.copy().transform(mat);
         } else if (a instanceof Number d && b instanceof FiguraVec4 vec) {
             return (vec.scaled(d.doubleValue()));
         }