Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 4.8 Memory Leak #65

Closed
Tracked by #4
kenny-sellers opened this issue Jan 11, 2022 · 1 comment · Fixed by #72
Closed
Tracked by #4

.NET 4.8 Memory Leak #65

kenny-sellers opened this issue Jan 11, 2022 · 1 comment · Fixed by #72
Labels
🐛 Bug Something isn't working

Comments

@kenny-sellers
Copy link
Collaborator

kenny-sellers commented Jan 11, 2022

Description

It was discovered that we are seeing a memory leak in FileOnQ.Imaging.Heif when targeting .NET 4.8. Both the thumbnail (234B) and primary image (234B) are impacted. Below is the benchmarks.

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated Allocated native memory Native memory leak
Thumbnail_Write 29.09 ms 0.211 ms 0.187 ms - - - 74,504 B 5,125,345 B 234 B
Thumbnail_ToArray 28.79 ms 0.171 ms 0.160 ms - - - 74,504 B 5,124,925 B 234 B
Thumbnail_ToSpan 29.12 ms 0.258 ms 0.215 ms - - - - 5,124,909 B 234 B
Thumbnail_ToStream 29.11 ms 0.366 ms 0.343 ms - - - 140,816 B 5,124,925 B 234 B
Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated Allocated native memory Native memory leak
PrimaryImage_Write 1.342 s 0.0043 s 0.0038 s - - - 1,951,112 B 222,030,860 B 234 B
PrimaryImage_ToArray 1.343 s 0.0031 s 0.0028 s - - - 1,951,112 B 222,030,552 B 234 B
PrimaryImage_ToSpan 1.342 s 0.0057 s 0.0053 s - - - - 222,029,928 B 234 B
PrimaryImage_ToStream 1.341 s 0.0043 s 0.0038 s - - - 3,894,032 B 222,030,392 B 234 B
@kenny-sellers kenny-sellers added 🐛 Bug Something isn't working ⚒ Enhancement New feature or request and removed 🐛 Bug Something isn't working ⚒ Enhancement New feature or request labels Jan 11, 2022
@SkyeHoefling
Copy link
Contributor

Thanks for writing this up @kenny-sellers

This was identified as part of #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants