Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional maxSize param varible #7

Merged
merged 2 commits into from Feb 6, 2014
Merged

Add additional maxSize param varible #7

merged 2 commits into from Feb 6, 2014

Conversation

coderaiser
Copy link
Contributor

4096 it's good default, but would be great to change it to another one :), for example I have 6KB font and would like move it to css also.

So I add additional parameter maxSize which could be used or not. Backward compatible saved.

@Filirom1
Copy link
Owner

Filirom1 commented Feb 6, 2014

I would prefer if you pass an options object, between rootPath and callback.

Callback should stay the last arguments because this is a node covention.
This will be a breaking change in the API. We will update the major version

@coderaiser
Copy link
Contributor Author

I agree with you, would be better if callback will be always last parameter so I add options parameter.

@Filirom1
Copy link
Owner

Filirom1 commented Feb 6, 2014

Great ;)

Filirom1 added a commit that referenced this pull request Feb 6, 2014
Add additional maxSize param varible
@Filirom1 Filirom1 merged commit 970cd70 into Filirom1:master Feb 6, 2014
@Filirom1
Copy link
Owner

Filirom1 commented Feb 6, 2014

npm publish
+ css-b64-images@0.2.4

@coderaiser
Copy link
Contributor Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants