Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop on Windows #4

Closed
MajorBreakfast opened this issue Apr 6, 2014 · 2 comments
Closed

Endless loop on Windows #4

MajorBreakfast opened this issue Apr 6, 2014 · 2 comments

Comments

@MajorBreakfast
Copy link
Contributor

function check() {
  console.log(dir);
  return false;
}

findup(process.cwd(), check, cb);

cb is never called. Instead the output is:

C:\
C:\
C:\
C:\
C:\
C:\
...

This also happens if I define the file via string, e.g. 'config.json'.

I didn't test it on Mac but my guess is that this is a Windows thing.

@MajorBreakfast
Copy link
Contributor Author

Must be because of https://github.com/Filirom1/findup/blob/master/index.js#L68
This is not a very good end condition then :)

@MajorBreakfast
Copy link
Contributor Author

Closing this in favor of PR #5

@Filirom1 Filirom1 reopened this Apr 7, 2014
Filirom1 added a commit that referenced this issue Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants