Various fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: it appears that travis-ci will always fail because it doesn't have makepkg. But, everything else works. |
|
Hi Claire, You now have the right to merge PR on this repo. Feel free to commit and push. Could you give me your npm login ? I will add you as a project owner. Cheers |
|
I didn't have an NPM login, but I just made one and my handle is Undeterminant. Thank you! |
ghost
merged commit
|
It's good !
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a fix for #2, fixes a warning where path.existsSync is deprecated, fixes an error that was introduced when I forgot to remove
stdin.resume()after making my previous pull request, and made tests work.I decided that removing the comments at the top of the PKGBUILD was the best choice for #2 because imo, if you don't know that you should add them, you shouldn't be using them in the first place. If you have a better option for this, I'm open to fixing it, otherwise, this should be fine.