truststore_nss: retry certtool with sudo when it fails due to permissions #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfay I made a smaller version fo your fix, could you test that it works? Thank you! |
FiloSottile
force-pushed
the
execCerttool
branch
from
0ddde5f
to
edc487d
Compare
FiloSottile
force-pushed
the
execCerttool
branch
from
edc487d
to
28654f2
Compare
|
Tested with a simple Docker image, seems to work. |
|
@FiloSottile Tested manually on Ubuntu 16.04, works. Reverted the workaround in our testing environmen (so it now gets Linuxbrew version v1.4.1) and that's working too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @rfay's investigation and fix.
Fixes #192
Closes #193