Remove unnecessary Marshal & Unmarshal operations from the code #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sns package will be used instead of SQS to publish the concept events returned by `concepts-rw-neo4j`. In this way more than one service would be able to consume them.
Allow multiple consumers of concept updates by refactoring AGGY to publish them in SNS topic instead of SQS.
The `sqs` package won't be used to SendEvents anymore. Instead AGGY will use SNS to publish events. There is no point in keeping logic and models which won't be used. Also previously it was possible to create a new sqs client with empty queueURL because in US there isn't a concepts events queue.
`n.UUID` is a shared variable in the anonymous func, instead `update.UUID` must be logged.
ivanruski
force-pushed
the
fix/unnecessary-operations
branch
from
31e5b80
to
f3e6bea
Compare
ivanruski
force-pushed
the
feature/UPPSF-4343-sns
branch
2 times, most recently
from
d49dddf
to
33f52f8
Compare
ManoelMilchev
force-pushed
the
feature/UPPSF-4343-sns
branch
from
33f52f8
to
61785ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary operations which have no real value on the correctness of the program.
Scope and particulars of this PR (Please tick all that apply)
DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"
This Pull Request follows the rules described in our Pull Requests Guide