Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change lifecycle and platform version for SV annotations #86

Merged
merged 1 commit into from Nov 17, 2023

Conversation

asparuhft
Copy link
Contributor

@asparuhft asparuhft commented Nov 15, 2023

Description

What

Change lifecycle and platform version for SV annotations

Why

JIRA Ticket UPPSF-4737

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to .E.g

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"

  • Test coverage is not significantly decreased
  • All PR checks have passed
  • Changes are deployed on dev before asking for review
  • Documentations remains up-to-date
    • OpenAPI definition file is updated
    • README file is updated
    • Documentation is updated in upp-docs and upp-public-docs
    • Architecture diagrams are updated

This Pull Request follows the rules described in our Pull Requests Guide

@asparuhft asparuhft requested a review from a team as a code owner November 15, 2023 14:11
@coveralls
Copy link

Coverage Status

coverage: 55.964%. remained the same
when pulling f65d868 on feature/UPPSF-4737
into d2c3b2f on master.

@ManoelMilchev ManoelMilchev requested a review from a team November 15, 2023 14:17
@asparuhft asparuhft merged commit 377d8c1 into master Nov 17, 2023
3 checks passed
@asparuhft asparuhft deleted the feature/UPPSF-4737 branch November 17, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants