Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unrollContent parameter #128

Conversation

vlasakievft
Copy link
Contributor

@vlasakievft vlasakievft commented Oct 9, 2023

Description

What

Why

UPPSF-4660

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to .E.g

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

DoD - Ensure all relevant tasks are completed before marking this PR as "Ready for review"

  • Test coverage is not significantly decreased
  • All PR checks have passed
  • Changes are deployed on dev before asking for review
  • Documentations remains up-to-date
    • OpenAPI definition file is updated
    • README file is updated
    • Documentation is updated in upp-docs and upp-public-docs
    • Architecture diagrams are updated

This Pull Request follows the rules described in our Pull Requests Guide

Signed-off-by: Veselin Vlasakiev <veselin.vlasakiev@ft.com>
@coveralls
Copy link

coveralls commented Oct 9, 2023

Coverage Status

coverage: 91.88% (+0.005%) from 91.875% when pulling 6f809d3 on feature/UPPSF-4660-request-to-enriched-content-api-with-certain-parameters-is-causing-error-500 into 3934f8d on master.

@vlasakievft vlasakievft marked this pull request as ready for review October 9, 2023 16:12
@vlasakievft vlasakievft requested review from a team as code owners October 9, 2023 16:12
@vlasakievft vlasakievft merged commit 0a1e84e into master Oct 10, 2023
4 checks passed
@vlasakievft vlasakievft deleted the feature/UPPSF-4660-request-to-enriched-content-api-with-certain-parameters-is-causing-error-500 branch October 10, 2023 06:39
@vlasakievft vlasakievft restored the feature/UPPSF-4660-request-to-enriched-content-api-with-certain-parameters-is-causing-error-500 branch October 10, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants