This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
Fix relationships in jsdoc #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 9, 2018 16:06
There's a legit use case here (aside from my happiness and sanity) JSDoc doesn't recognise the comments for dynamically generated relationship functions, as the previous statement is not terminated by a semi-colon When adding a semi-colon to the previous statement, the docs are generated correctly
Limess
force-pushed
the
relationship-docs
branch
from
7808c44
to
688bab1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relationships weren't appearing in the jsdocs due to no semi-colon separating the statement above the dynamic relationship definition.
This is a quirk in jsdoc parsing and I'm not sure of a way to fix it, so I unreluctantly enabled semi-colons on everything in prettier.