This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
Add the parsed response body to error objects #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas42
reviewed
May 22, 2018
src/lib/required.js
Outdated
| * @function | ||
| * @example | ||
| * myFunction({ | ||
| * requiredParameter = required('requiredParameter) |
There was a problem hiding this comment.
This appears to be missing a close quote mark
There was a problem hiding this comment.
Was wondering why that was garish. Fixed.
added 4 commits
May 29, 2018 11:24
This ensures that _fetch_ is used for all calls, which does consistent error handling. The body is now parsed as json and added to all calls. If this parsing fails, an error is still thrown, but the body is omitted
|
Merging this in absence of any review uptake. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to do some conditional handling in dewey-web. Everything now also uses the same response parsing logic, before there were 3 separate paths.